Skip to content

Fix failing history unit test#8682

Merged
Martin-Molinero merged 2 commits intoQuantConnect:masterfrom
jhonabreul:bug-failing-unit-test
Apr 8, 2025
Merged

Fix failing history unit test#8682
Martin-Molinero merged 2 commits intoQuantConnect:masterfrom
jhonabreul:bug-failing-unit-test

Conversation

@jhonabreul
Copy link
Copy Markdown
Collaborator

Description

Add algorithm start date so period-based history request is consistent in QuantBookTests.HistoryDataDoesnNotReturnDataLabelWithBaseDataCollectionTypesAndPeriods.

Related Issue

N/A

Motivation and Context

N/A

Requires Documentation Change

N/A

How Has This Been Tested?

Unit test passes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Add algorithm start date so period history request is consistent
Copy link
Copy Markdown
Member

@Martin-Molinero Martin-Molinero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Martin-Molinero Martin-Molinero merged commit 1e4ef83 into QuantConnect:master Apr 8, 2025
7 of 8 checks passed
@jhonabreul jhonabreul deleted the bug-failing-unit-test branch April 8, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants