Skip to content

Fix infinite recursion in MarketHoursDatabase when force-exchange-always-open is true#8772

Merged
jhonabreul merged 1 commit into
QuantConnect:masterfrom
JosueNina:bug-8736-stack-over-flow-exception-in-always-open-market-hours
Jun 3, 2025
Merged

Fix infinite recursion in MarketHoursDatabase when force-exchange-always-open is true#8772
jhonabreul merged 1 commit into
QuantConnect:masterfrom
JosueNina:bug-8736-stack-over-flow-exception-in-always-open-market-hours

Conversation

@JosueNina

Copy link
Copy Markdown
Collaborator

Description

This PR fixes an infinite recursion issue that occurred in MarketHoursDatabase when the force-exchange-always-open config flag was enabled.

Related Issue

Closes #8736

Motivation and Context

N/A

Requires Documentation Change

N/A

How Has This Been Tested?

It was tested using unit test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@jhonabreul jhonabreul left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JosueNina JosueNina force-pushed the bug-8736-stack-over-flow-exception-in-always-open-market-hours branch from 40529ed to e194e2e Compare May 15, 2025 22:19
@JosueNina JosueNina force-pushed the bug-8736-stack-over-flow-exception-in-always-open-market-hours branch from e194e2e to bb87764 Compare May 15, 2025 22:26

@Martin-Molinero Martin-Molinero left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jhonabreul jhonabreul merged commit 29ab1d6 into QuantConnect:master Jun 3, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StackOverflowException in AlwaysOpenMarketHoursDatabaseImpl

3 participants