Skip to content

Restrict supported order types in Bitfinex brokerage#8776

Merged
Martin-Molinero merged 6 commits into
QuantConnect:masterfrom
JosueNina:bug-8673-bitfinex-does-not-define-supported-order-types
Jun 3, 2025
Merged

Restrict supported order types in Bitfinex brokerage#8776
Martin-Molinero merged 6 commits into
QuantConnect:masterfrom
JosueNina:bug-8673-bitfinex-does-not-define-supported-order-types

Conversation

@JosueNina

Copy link
Copy Markdown
Collaborator

Description

Updated Bitfinex brokerage model to explicitly define supported order types (Market, Limit, StopMarket) and reject unsupported types with proper warning messages.

Related Issue

Closes #8673

Motivation and Context

N/A

Requires Documentation Change

N/A

How Has This Been Tested?

It was tested using a regression algorithm.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@JosueNina JosueNina force-pushed the bug-8673-bitfinex-does-not-define-supported-order-types branch from 642c369 to dbae0c1 Compare May 19, 2025 22:31

@jhonabreul jhonabreul left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

OrderType.Market,
OrderType.StopMarket
OrderType.StopMarket,
OrderType.StopLimit

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@Martin-Molinero Martin-Molinero merged commit ba931a2 into QuantConnect:master Jun 3, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BitfinexBrokerageModel Doesn't Define Supported Order Types

3 participants