feature: recognise equity tape letters S/V/H/U and add NASDAQ_SC#9422
Merged
Romazes merged 4 commits intoApr 21, 2026
Conversation
- map primary exchange codes S and T to new NASDAQ tier exchanges - T was previously folded into NASDAQ, now returns NASDAQ_INT - add V as alias for IEX in equity switch - fix MEMX description (was copy of LTSE)
27ec3e0 to
206f99f
Compare
6 tasks
Remove the separate NASDAQ_INT mapping in GetPrimaryExchange and map
exchange code "T" to NASDAQ_SC. Update ExchangeTest cases accordingly
and add coverage for IEX ("V") and MEMX ("U").
Drop the NASDAQ_INT class entry from Exchange.cs. The "T" tape letter already routes to Exchange.NASDAQ via GetPrimaryExchange, leaving the class definition unreachable and inconsistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extend the equity branch of
Exchanges.GetPrimaryExchangeto recognise tape letters that previously fell through toExchange.UNKNOWN(or to a long-form alias only), addNASDAQ_SC(andNASDAQ_INT) as newExchangeentries, and fix the copy-paste typo inExchange.MEMX's description.SNASDAQ_SCUNKNOWNVIEX"IEX"recognisedHMIAX_PEARLUNKNOWNUMEMXUNKNOWNExchange.NASDAQ_INTis added as a class entry for direct reference; the"T"tape letter continues to route toExchange.NASDAQfor backward compatibility.Motivation and Context
Brokerage and market-data feeds emit these tape letters in primary-exchange fields, but the equity switch in
GetPrimaryExchangedid not cover them.Evidence for each mapping
SVIEXG)HURequires Documentation Change
No
How Has This Been Tested?
Extended
Tests/Common/ExchangeTest.cs:ExchangeCorrectlyReturnedAsSingleLetter— round-trip[TestCase]forNASDAQ_SC.ExchangeCases— new rows forS→NASDAQ_SC,H→MIAX_PEARL,V→IEX,U→MEMX.Types of changes
Checklist