-
Notifications
You must be signed in to change notification settings - Fork 13
feat!: TypeRow: add conversion from array, remove from type #2784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #2784 will improve performance by 44.01%Comparing Summary
Benchmarks breakdown
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2784 +/- ##
=======================================
Coverage 83.69% 83.69%
=======================================
Files 261 261
Lines 52551 52574 +23
Branches 47307 47330 +23
=======================================
+ Hits 43981 44003 +22
- Misses 6183 6184 +1
Partials 2387 2387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
suggested "BREAKING CHANGE" notice: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree pretty strongly that implicitly converting T to Vec makes it much harder for the rust type system to find bugs for us and causes (me) confusion, so I'm very happy with this change. Will defer the utility/performance of TypeRow to future discussions.
This somewhat looks forward to #2341 but seems like a good thing right now.
Removal of
impl from Type(RV) for TypeRow(RV)requires an extravec![...]at each callsite, but if we addimpl <const N: usize> From<[Type; N] for TypeRow(further parametrized by RV) then only two extra characters[...]are required, which seems bearable; and this strengthens the distinction between type and list-of-type.BREAKING CHANGE: implicit conversion from single Type to TypeRow removed, use array of single Type instead.