Skip to content

Comments

ci: post useful integration test messages#128

Merged
vanyae-cqc merged 2 commits intomainfrom
infra/integration-test-messages
Jan 13, 2025
Merged

ci: post useful integration test messages#128
vanyae-cqc merged 2 commits intomainfrom
infra/integration-test-messages

Conversation

@vanyae-cqc
Copy link
Collaborator

Adds a message to each PR with a reminder to reviewers to run the integration tests manually if required.

Also comments on each PR with a link to the integration test run (if/when it is run).

@vanyae-cqc vanyae-cqc requested a review from a team as a code owner January 8, 2025 15:31
@vanyae-cqc vanyae-cqc requested review from isobelhooper and removed request for a team January 8, 2025 15:31
@github-actions
Copy link

github-actions bot commented Jan 8, 2025

Hello and thank you for making a PR to qnexus! 👋
A maintainer will review and run integration tests if required.

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 8, 2025

Hello and thank you for making a PR to qnexus! 👋
A maintainer will review and run integration tests if required.

@ferbetanzo
Copy link
Collaborator

@vanyae-cqc Do you know why we got duplicated messages here? Or if new messages will be posted with each commit to the branch?

@vanyae-cqc vanyae-cqc changed the title infra: post useful integration test messages ci: post useful integration test messages Jan 8, 2025
@vanyae-cqc
Copy link
Collaborator Author

vanyae-cqc commented Jan 8, 2025

I originally put it in a workflow that got run twice (for two different python versions). Should be fixed now, but please let me know if you see any improvements/issues to this integration test process

@vanyae-cqc vanyae-cqc requested a review from ferbetanzo January 8, 2025 15:44
Copy link
Collaborator

@ferbetanzo ferbetanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vanyae-cqc vanyae-cqc merged commit 7e1fb30 into main Jan 13, 2025
6 of 7 checks passed
@vanyae-cqc vanyae-cqc deleted the infra/integration-test-messages branch January 13, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants