Conversation
|
Hello and thank you for making a PR to qnexus! 👋 |
4 similar comments
|
Hello and thank you for making a PR to qnexus! 👋 |
|
Hello and thank you for making a PR to qnexus! 👋 |
|
Hello and thank you for making a PR to qnexus! 👋 |
|
Hello and thank you for making a PR to qnexus! 👋 |
|
Hello and thank you for making a PR to qnexus! 👋 |
2 similar comments
|
Hello and thank you for making a PR to qnexus! 👋 |
|
Hello and thank you for making a PR to qnexus! 👋 |
|
Hello and thank you for making a PR to qnexus! 👋 |
|
Hello and thank you for making a PR to qnexus! 👋 |
|
Hello and thank you for making a PR to qnexus! 👋 |
|
Hello and thank you for making a PR to qnexus! 👋 |
|
Hello and thank you for making a PR to qnexus! 👋 |
2 similar comments
|
Hello and thank you for making a PR to qnexus! 👋 |
|
Hello and thank you for making a PR to qnexus! 👋 |
|
Hello and thank you for making a PR to qnexus! 👋 |
|
Hello and thank you for making a PR to qnexus! 👋 |
| return main.compile() | ||
|
|
||
|
|
||
| def test_guppy_execution( |
There was a problem hiding this comment.
Given the comments (and the reality) about the QSYS QA device not always being online, should we consider marking this test with @Skip for now?
Also - if the env var "NEXUS_QA_QSYS_DEVICE" is not present, this python file will raise an exception on import. Maybe we could skip_if the env var is absent. Then normal runs of the tests will continue to work as before. Just a suggestion though
There was a problem hiding this comment.
We could certainly, wasn't sure what the best approach was here but wanted to make sure there was at least some sort of test. Think its ok to @Skip for now and then look towards a proper test device in the future (e.g. selene)
qnexus/models/references.py
Outdated
| ) | ||
|
|
||
|
|
||
| P = TypeVar("P", CircuitRef, HUGRRef) |
There was a problem hiding this comment.
Rename or remove this (unused, I think)
Co-authored-by: Richard Morrison <141632498+quantinuum-richard-morrison@users.noreply.github.com>
|
Hello and thank you for making a PR to qnexus! 👋 |
|
Hello and thank you for making a PR to qnexus! 👋 |
|
Hello and thank you for making a PR to qnexus! 👋 |
quantinuum-richard-morrison
left a comment
quantinuum-richard-morrison
left a comment
There was a problem hiding this comment.
Approving - note that importing integration/test_qsys_jobs will still throw an exception unless the NEXUS_QA_QSYS_DEVICE environment variable is present
I guess I tried to clarify that in the /integration readme, but reasonable to just put it in the skipped test I suppose |
|
Hello and thank you for making a PR to qnexus! 👋 |
2 participants
Uh oh!
There was an error while loading. Please reload this page.