refactor: Move borrow array linearizer helper functions to tket and make them public - #1951
Open
hsemenenko wants to merge 2 commits into
Open
refactor: Move borrow array linearizer helper functions to tket and make them public#1951hsemenenko wants to merge 2 commits into
tket and make them public#1951hsemenenko wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1951 +/- ##
==========================================
+ Coverage 86.60% 86.66% +0.05%
==========================================
Files 202 202
Lines 32644 32449 -195
Branches 31158 30963 -195
==========================================
- Hits 28271 28121 -150
+ Misses 3089 3045 -44
+ Partials 1284 1283 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
maximilianruesch
changed the title
tket and make publictket and make them public
doug-q
reviewed
Aug 28, 2026
| // `Futures`. Note we don't need to deal with static arrays as you cannot | ||
| // create static arrays of `Measurement`` values in Guppy. | ||
| replace_array_ops_requiring_copyable_bounds(lowerer); | ||
| register_linear_array_op_replacements(lowerer); |
Contributor
There was a problem hiding this comment.
Why are you renaming the function?
Contributor
Author
There was a problem hiding this comment.
The previous name wasn't accurate. The function is not doing the replacement, but registering the replacement with the lowerer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1950.