refactor: standardize async IPC handlers through action registry #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phase 1 of IPC async standardization. Chat send-message now dispatches through a registered action instead of directly dispatching the effect from the IPC boundary. This makes async chat capabilities discoverable in the action registry. - Created main/actions/chat.cljs with send-message-from-ipc action - Registered action in main/actions.cljs - Updated IPC handler to dispatch action instead of effect 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Standardizes workspace/reload IPC handler to dispatch through the action registry instead of directly dispatching effects. This makes the reload capability discoverable alongside other workspace actions and follows the established pattern from workspace/pick-folder. Changes: - Add reload action to workspace.cljs that extracts workspace-dir from state - Register workspace.actions/reload in main action registry - Update IPC handler to dispatch action instead of effect directly 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Updated architecture documentation in main/core.cljs to explain both sync and async IPC handler patterns. Sync handlers use direct effect pipelines when returning values; async handlers dispatch through the action registry for discoverability. Added inline comments for each handler group following existing informal style. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardizes async IPC handlers (
chat/send-message,workspace/reload) to dispatch registered Nexus actions instead of effects directly, making all async system capabilities discoverable in the action registry. Sync IPC handlers that must return values (topic/save,topic/delete,secrets/*) maintain their direct effect pipeline pattern as documented. Expanded architecture documentation inmain/core.cljsto explain when to use each pattern and why the hybrid approach is intentional.