fix: restore LLM integration tests by separating fetch from normalization #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracts provider-specific HTTP calls into fetch-provider-response multimethod. New query-llm-provider function composes fetch + normalization. No behavior change to public API. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Integration tests now call fetch-provider-response and validate that mock fixtures accurately represent real API responses. This ensures mocks used in unit tests stay synchronized with actual provider APIs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration tests were broken after previous LLM refactoring that combined HTTP fetching with response normalization. This PR separates
fetch-provider-response(raw API calls) from normalization logic, allowing integration tests to validate actual API response structures. Tests now include comprehensive structural validation for all three providers (Anthropic, OpenAI, Gemini) with checks for nested fields, API contracts, and token metadata.