-
-
Notifications
You must be signed in to change notification settings - Fork 487
Add support for emotes in flairs #1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for emotes in flairs #1054
Conversation
This is incomplete. I want to limit the emote height so it can't be taller than 2x the height of the text (or whatever multiple looks good). Currently I'm just halving the emote and it mostly works with my device and font size but that's obviously an imperfect solution. @QuantumBadger , Any thoughts on what the best way to do this would be? |
The best solution I came up with is this:
I got the text size from reddit_comment.xml. I'd like to get it programmatically instead of hard-coding it but I don't see an obvious way to do that. |
df57a22
to
c111015
Compare
Thank you for this @bharatknv and sorry for the very delayed response, there's a backlog of PRs that I'm just now clearing up!
That looks fine to me. I've adjusted |
Merged and changelog updated -- thanks again! |
Adds #1042