-
-
Notifications
You must be signed in to change notification settings - Fork 487
Layout mode #1262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
edgan
wants to merge
13
commits into
QuantumBadger:master
Choose a base branch
from
edgan:layout-mode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Layout mode #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@edgan Thank you for this, and sorry for the slow review time. This looks interesting and I'll get around to it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
I tested toggling between all three modes repeatedly. I also made sure the layout was as expected per mode. I did this testing on my Google Pixel 8 Pro running Android 15.
I did the translations for languages that I could find the
prefs_category_images_video
string within the file for that language. I double checked the translations. Added dates to the translation additions to follow what seem be a convention.IMHO, all these features combined massive improves the usability in image dominated subreddits like
/r/pics
.Layout modes:
Screenshots
Layout mode preference:
Screenshot
RedReader Post header preview:
Screenshots
RedReader reddit album/gallery image preview:
Screenshots