Skip to content

Remove random / randomNSFW shortcuts #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2025

Conversation

vafada
Copy link
Contributor

@vafada vafada commented Feb 2, 2025

fixes #1263

removes the random and random NSFW shortcut since https://old.reddit.com/r/random is now a banned subreddit making this feature useless

@vafada vafada changed the title Remove random Remove random / randomNSFW shortcuts Feb 2, 2025
@QuantumBadger
Copy link
Owner

Thanks @vafada, sorry for the slow review!

Mostly looks good, but we should avoid changing the non-English strings.xml files, as that causes merge conflicts with Weblate.

@vafada
Copy link
Contributor Author

vafada commented Apr 3, 2025

@QuantumBadger pr updated

android studio is messing with new line at the end of the file on some non-english xml

is that okay?

nevermind. fixed. diff much cleaner

QuantumBadger added a commit to vafada/RedReader that referenced this pull request Apr 20, 2025
QuantumBadger pushed a commit to vafada/RedReader that referenced this pull request Apr 20, 2025
QuantumBadger added a commit to vafada/RedReader that referenced this pull request Apr 20, 2025
QuantumBadger added a commit to vafada/RedReader that referenced this pull request Apr 20, 2025
@QuantumBadger QuantumBadger merged commit 2aeadbf into QuantumBadger:master Apr 20, 2025
1 check passed
QuantumBadger pushed a commit that referenced this pull request Apr 20, 2025
@QuantumBadger
Copy link
Owner

Thanks @vafada! I fixed a crash which occurred if the user had these options enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reddit has removed the /r/random/ feature
2 participants