Conversation
Codecov ReportAttention: Patch coverage is
|
lkdvos
left a comment
There was a problem hiding this comment.
Is this ever a bottleneck? Because this definitely nontrivially changes the algorithm by doing it in parallel, because every bond update is assuming the other sites to be constant, and this implementation breaks that assumption. It might indeed be the case that this does not matter, you're interested in getting the spaces approximately right, but I'm somewhat less confident about this
I just had some code running where this took about half a day. And bond dimensions are still growing. I wouldn't say its the biggest bottleneck but I was parallelizing stuff anyways so I thought, why not... I agree that this changes the algorithm, hence my choice to explicitly retain the old algorithm in the non parallel case. |
This PR also makes vumpSVD parallel.
Again tests have been implemented in another PR and I've tested the combined PR locally on my machine :)