Skip to content

Add some basic support for svd_trunc_no_error#390

Draft
kshyatt wants to merge 2 commits into
mainfrom
ksh/svd_no_error
Draft

Add some basic support for svd_trunc_no_error#390
kshyatt wants to merge 2 commits into
mainfrom
ksh/svd_no_error

Conversation

@kshyatt
Copy link
Copy Markdown
Member

@kshyatt kshyatt commented Jun 1, 2026

My goal here is to start allowing users to set in the algorithm whether or not they want the truncation error computed. The benefit of not computing it is increased speed and possibly some AD benefits. For now I've done the easiest part -- hooking up svd_trunc_no_error, adding ChainRules.jl pullback support, and adding tests. Next is to figure out a nice way to control when to use it in the actual CTMRG functions themselves.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

❌ Patch coverage is 34.92063% with 41 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/utility/svd.jl 34.92% 41 Missing ⚠️
Files with missing lines Coverage Δ
src/utility/svd.jl 66.50% <34.92%> (-13.64%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

Your PR no longer requires formatting changes. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant