Add some basic support for svd_trunc_no_error#390
Draft
kshyatt wants to merge 2 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My goal here is to start allowing users to set in the algorithm whether or not they want the truncation error computed. The benefit of not computing it is increased speed and possibly some AD benefits. For now I've done the easiest part -- hooking up
svd_trunc_no_error, addingChainRules.jlpullback support, and adding tests. Next is to figure out a nice way to control when to use it in the actual CTMRG functions themselves.