Update sector tests#44
Draft
borisdevos wants to merge 14 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Member
|
When you say these tests fail, do you mean the tolerance is just set too high? Because that might be fair for higher-dimensional irreps |
Member
Author
|
No, it can already mismatch at the 2nd decimal. Here a quick example: |
…tions.jl into bd/update-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the sector testsuite from TensorKitSectors.
Currently a draft because the Artin braid test fails for high enough dimensional irreps involved for some reason, but passes for many others. The current
maxdim = 15tosmallsetwill probably not catch these errors, I just wanted to otherwise show it's fine. Very confusing to me at the moment.