Skip to content

Update sector tests#44

Open
borisdevos wants to merge 16 commits into
mainfrom
bd/update-tests
Open

Update sector tests#44
borisdevos wants to merge 16 commits into
mainfrom
bd/update-tests

Conversation

@borisdevos

@borisdevos borisdevos commented Mar 16, 2026

Copy link
Copy Markdown
Member

Use the sector testsuite from TensorKitSectors.

Currently a draft because the Artin braid test fails for high enough dimensional irreps involved for some reason, but passes for many others. The current maxdim = 15 to smallset will probably not catch these errors, I just wanted to otherwise show it's fine. Very confusing to me at the moment.

@codecov

codecov Bot commented Mar 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/clebschgordan.jl 98.63% <100.00%> (+1.31%) ⬆️
src/sector.jl 93.82% <100.00%> (-4.75%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkdvos

lkdvos commented Mar 16, 2026

Copy link
Copy Markdown
Member

When you say these tests fail, do you mean the tolerance is just set too high? Because that might be fair for higher-dimensional irreps

@borisdevos

Copy link
Copy Markdown
Member Author

No, it can already mismatch at the 2nd decimal. Here a quick example:
isapprox([0.49357987913169243; 0.3608970552458627; 0.12256062712019984;;;;], [0.4796164601864595; 0.3801689443717772; 0.11970177000507069;;;;]; atol = 1.0e-12, rtol = 1.0e-12)
As far as I've seen it's also always the underbraiding path which fails. I'm curious if this also gets picked up in the fusion tree braid tests

@borisdevos borisdevos marked this pull request as ready for review June 3, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants