Conversation
Member
|
We'll need another version after to support TK 0.17.0 also |
Member
Author
|
Yes, although I think that will just be a compat increase so we can support both versions simultaneously. Might as well get this one out though |
Member
|
Should we just update the |
Member
Author
|
I was thinking the same thing, but then decided against that, since v0.17 isn't even released yet, if we decide on adding something to that release that is breaking, we now have a registered version with wrong compat bounds, which tends to be a pain because the only way to "fix" that is to yank it from the registry. Ultimately I don't think it's that much effort to just include the v0.17 in TensorKitManifolds v0.8.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the CompatHelper workflow for a dependabot one, and updates the Project.toml to work with a test/Project.toml.
I also noticed that the last register request didn't go through (it needs the "breaking changes" text), so I will register this version (0.8.0) again.