move BCH code to QECCore

lib/QECCore/ext/QECCoreNemoExt/QECCoreNemoExt.jl

@@ -5,8 +5,8 @@ using DocStringExtensions
 
 import Nemo
 import Nemo: GF, gen, matrix, rank, transpose, polynomial_ring, evaluate, FqFieldElem,
-    FqPolyRingElem, degree, is_irreducible, gcd, derivative, inv, coeff, is_monic, one
-
+    FqPolyRingElem, degree, is_irreducible, gcd, derivative, inv, coeff, is_monic, one,
+    minpoly, lcm, is_zero, finite_field
 import QECCore: code_k, parity_matrix_x, parity_matrix_z, parity_matrix, generator_polynomial
 
 import Random
@@ -30,6 +30,7 @@ function QECCore.code_k(c::AbstractCECC)
     return n - rank_H
 end
 
+include("bch.jl")
 include("goppa.jl")
 
 end # module

lib/QECCore/src/QECCore.jl

@@ -23,7 +23,7 @@ DelfosseReichardt, DelfosseReichardtRep, DelfosseReichardt823, QuantumTannerGrap
 TillichZemor, random_TillichZemor_code, BivariateBicycleViaCirculantMat
 
 # Classical Codes
-export RepCode, ReedMuller, RecursiveReedMuller, Golay, Hamming, random_Gallager_ldpc, Goppa, random_Goppa_code
+export RepCode, ReedMuller, RecursiveReedMuller, Golay, Hamming, random_Gallager_ldpc, Goppa, random_Goppa_code, BCH
 
 # utilities
 export search_self_orthogonal_rm_code, hgp
@@ -37,6 +37,7 @@ include("codes/classical/repetition.jl")
 include("codes/classical/golay.jl")
 include("codes/classical/gallager.jl")
 include("codes/classical/goppa.jl")
+include("codes/classical/bch.jl")
 
 # Quantum Codes
 include("codes/quantum/css.jl")

lib/QECCore/src/codes/classical/bch.jl

@@ -0,0 +1,8 @@
+"""BCH codes ([hocquenghem1959codes](@cite), [bose1960class](@cite))."""
+function BCH(args...; kwargs...)
+    ext = Base.get_extension(QECCore, :QECCoreNemoExt)
+    if isnothing(ext)
+        throw("The `BCH` depends on the package `Nemo` but you have not installed or imported it yet. Immediately after you import `Nemo`, the `BCH` will be available.")
+    end
+    return ext.BCH(args...; kwargs...)
+end

test/test_ecc_bch.jl → lib/QECCore/test/codes/bch.jl

@@ -1,10 +1,10 @@
-@testitem "ECC BCH" tags=[:ecc, :ecc_bespoke_checks] begin
+@testitem "ECC BCH" begin
     using LinearAlgebra
+    using QECCore 
     using QuantumClifford.ECC
-    using QuantumClifford.ECC: AbstractECC, BCH, generator_polynomial
     using Nemo: ZZ, residue_ring, matrix, finite_field, GF, minpoly, coeff, lcm, FqPolyRingElem, FqFieldElem, is_zero, degree, defining_polynomial, is_irreducible
 
-    using QuantumClifford.ECC.QECCore: code_k, code_n, distance, rate, parity_matrix
+    using QECCore: code_k, code_n, distance, rate, parity_matrix, BCH, generator_polynomial
 
     # To prove that t-bit error correcting BCH code indeed has minimum distance
     # of at least 2 * t + 1, it is shown that no 2 * t or fewer columns of its

src/ecc/ECC.jl

@@ -401,7 +401,6 @@ include("codes/util.jl")
 
 include("codes/concat.jl")
 include("codes/random_circuit.jl")
-include("codes/classical/bch.jl")
 
 # qLDPC
 include("codes/classical/lifted.jl")