Fix #601: Optimized code_n dimension execution to O(1) for bigger codes#702
Open
the-punisher-29 wants to merge 1 commit into
Open
Fix #601: Optimized code_n dimension execution to O(1) for bigger codes#702the-punisher-29 wants to merge 1 commit into
the-punisher-29 wants to merge 1 commit into
Conversation
…or bigger codes
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #702 +/- ##
==========================================
+ Coverage 73.88% 74.81% +0.92%
==========================================
Files 111 111
Lines 7725 7636 -89
==========================================
+ Hits 5708 5713 +5
+ Misses 2017 1923 -94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeping this as a draft , was facing some issues with Oscar compilation on Julia 1.12 on my machine, so although i ran this (ECC_TEST="base" julia --project=. -e 'using Pkg; Pkg.test("QuantumClifford")') test, im'not sure 100%
. I checked the formulas against the base framework , but I will wait for the tests here and once everything is good,i'll mark this ready.
The problem (#601, found while testing #594): property tests on the bigger extension-aware codes (Tricycles, Homological Products, Tanner variants) were hitting O(N³) because the framework was building entire parity matrices just to count columns for code_n.
What I did in this:
here is some of the codes i worked on (code family name and then on right its formula for code_n)
GeneralizedToric — 2αβ
α×β lattice has αβ horizontal + αβ vertical edges
DelfosseReichardt — p · 2^m
Kronecker product of H₁ (p cols) and Reed-Muller H_RM (2^m cols)
QuantumTannerGraphProduct — n₁n₂ + m₁m₂
Qubits sit on faces of the product complex: E₁×E₂ and V₁×V₂
CyclicQuantumTannerGraphProduct — 8m²
Symmetric bipartite subgraphs with 4m vertices and degree 2m each
TrivariateTricycle — 3lmp
3 circulant blocks over polynomial ring with cyclic degrees l, m, p
ExtendedGeneralizedBicycle — 2mℓ
2-block bicycle structure with ring depth scaled by expansion index m
GeneralizedHyperGraphProduct — 2 · rows(A) · ℓ
Tensor sum rℓ + cℓ, and the constructor forces A to be square (r = c)
MultivariateMulticycle — C(t, t/2) · ∏|Gᵢ|
Koszul complex of length t; qubits live at middle dimension t/2
HomologicalProduct — Σᵢ Rᵢ ∏ⱼ≠ᵢ Cⱼ
Künneth theorem: degree 1 needs exactly one factor at degree 1, rest at 0
DoubleHomologicalProduct — n⁴ + 4n²m² + m⁴
Künneth expansion over dual boundary layers at scales nm and n²+m²