Add missing distance computation checks for small bivariate bicycle codes#718
Open
satzgits wants to merge 1 commit into
Open
Add missing distance computation checks for small bivariate bicycle codes#718satzgits wants to merge 1 commit into
satzgits wants to merge 1 commit into
Conversation
…odes Resolves QuantumSavory#713 by adding DistanceMIPAlgorithm checks for codes with n<=98 where exact distances are known from literature (Bravyi et al., Wang et al.). - [[72, 12, 6]]: adds distance == 6 check - [[90, 8, 10]]: adds distance == 10 check - [[54, 8, 6]]: adds distance == 6 check - [[98, 6, 12]]: adds distance == 12 check
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #713 by adding
DistanceMIPAlgorithmchecks for small codes (n ≤ 98) where exact distances are known from the literature.Changes
distance(c, DistanceMIPAlgorithm(solver=HiGHS)) == <expected>checks for:[[72, 12, 6]](Bravyi et al. Table 3)[[90, 8, 10]](Bravyi et al. Table 3)[[54, 8, 6]](Wang et al. Table 1)[[98, 6, 12]](Wang et al. Table 1)These tests import
HiGHS,JuMP, andDistanceMIPAlgorithmbut did not previously invoke them. This PR validates the code construction beyond justcode_nandcode_k, ensuring the parity check matrices actually yield the expected distance properties for these small instances.cc @Krastanov