BBPSSWProt in the ProtocolZoo#313
Open
LBacciottini wants to merge 3 commits intoQuantumSavory:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented and incorporated the BBPSSW distillation protocol from https://arxiv.org/abs/quant-ph/9511027 into the ProtocolZoo.
Created a new file ProtocolZoo/distillation.jl that is now included in ProtocolZoo.jl, following the same style that was used for swapping.jl. This way, additional well-known distillation protocols (e.g. DEJMPS) can be added in the future to distillation.jl with minor/no changes to other files.
Tests for new functionalities implemented in the new file test/test_protocolzoo_distillation.jl
Note: I didn't edit the CHANGELOG file to avoid conflicts.
Before considering your pull request ready for review and merging make sure that all of the following are completed (please keep the clecklist as part of your PR):
If possible, keep your git history not too wild (rebase and squash commits, keep commits small and semantically separated) so that review is easier.