skip refundIsthmusOperatorCost for estimate_gas #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blockchaindevsh
requested review from
dajuguan,
ping-ke,
qizhou,
qzhodl and
syntrust
This was referenced Nov 21, 2025
qzhodl
reviewed
Nov 21, 2025
core/state_transition.go
Outdated
| } | ||
|
|
||
| if rules.IsOptimismIsthmus { | ||
| if rules.IsOptimismIsthmus && shouldCheckGasFormula { |
There was a problem hiding this comment.
It seems that the original logic is changed if we add shouldCheckGasFormula here
Collaborator
Author
There was a problem hiding this comment.
shouldCheckGasFormula is always true within consensus; it's only false for api calls like estimate_gas .
Collaborator
Author
There was a problem hiding this comment.
Strictly speak, this is an upstream issue, there's a related but un-merged pr here: ethereum-optimism#599 .
syntrust
approved these changes
Nov 22, 2025
Collaborator
Author
|
would like to also hear @qizhou 's opinion before merging. |
qizhou
reviewed
Nov 25, 2025
| return nil, fmt.Errorf("optimism l1 cost overflows U256: %d", l1Cost) | ||
| } | ||
| if shouldCheckGasFormula { | ||
| if shouldCheckGasFormula { |
There was a problem hiding this comment.
I guess you can put all shouldCheckGasFormula checks in one condition check rather than multiple ones.
Collaborator
Author
There was a problem hiding this comment.
Good point, done!
qizhou
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip
refundIsthmusOperatorCost()during gas estimation (whenshouldCheckGasFormulais false) since operator cost wasn't pre-charged.Fixes QuarkChain/optimism#130
UPDATE
l1 cost has the same issue, so also fixed.