fix libpq nonblocking connect readiness#1372
Closed
russellromney wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two TCP readiness issues that break libpq/psycopg's nonblocking connect path under Quark:
getsockopt(SO_ERROR)only has cachedEINPROGRESS, ask the host socket for the currentSO_ERROR; if the host reports success, clear the cached state and promote the socket throughPostConnect().Root cause
psycopg/libpq opens the TCP socket nonblocking, receives
EINPROGRESSfromconnect(2), and then immediately checksgetsockopt(SO_ERROR)before sending the PostgreSQL startup packet. Quark was still returning cachedEINPROGRESSuntil a later readiness path advanced the uring socket state.A separate select fdset typo caused sockets to appear in the exception fdset even after
SO_ERRORwas clear.Validation
Validated through Tinyhost's real droplet e2e against
postgres:16-alpine: