HyperSpectra: use a preselected colormap for some SNOM data#757
Draft
markotoplak wants to merge 1 commit intoQuasars:masterfrom
Draft
HyperSpectra: use a preselected colormap for some SNOM data#757markotoplak wants to merge 1 commit intoQuasars:masterfrom
markotoplak wants to merge 1 commit intoQuasars:masterfrom
Conversation
Member
|
Hi @markotoplak, thanks for trying to add this quickly. I think with this condition that currently it is not possible to change the colormap for those files we should just leave it in the original version, so no preselection of the colormap for now. Later, this could be an awesome feature too, but not so urgent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, @borondics, this is ALMOST what you wanted: two specific kinds of data get their own color maps.
So what is wrong with it? For those two data types users can not then change colors. If I allowed that and used the datatype as a hint in changing the actual settings, that setting would also (it is how settings work) influence the future HyperSpectra instances. I could make some more complex logic around it so that the setting would not be saved unless the user then manually changed it, but that is more complex and if not done carefully, could introduce more problems than it would solve.
This is it for for now. Take it or leave it...