Skip to content

XDG Base Directory compliance #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nelind3 wants to merge 1 commit into
base: master
Choose a base branch
from
+32 −4
Open

XDG Base Directory compliance #456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions src/main/java/net/querz/mcaselector/config/Config.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,11 @@ public abstract class Config {
BASE_CONFIG_FILE = getEnvFilesWithDefault(BASE_DIR.getAbsolutePath(), "mcaselector/settings.json", ';', "LOCALAPPDATA");
BASE_OVERLAYS_FILE = getEnvFilesWithDefault(BASE_DIR.getAbsolutePath(), "mcaselector/overlays.json", ';', "LOCALAPPDATA");
} else {
BASE_CACHE_DIR = getEnvFilesWithDefault("~/.cache", "mcaselector", ':', "XDG_CACHE_HOME", "XDG_CACHE_DIRS");
BASE_LOG_DIR = getEnvFilesWithDefault("~/.local/share", "mcaselector/log", ':', "XDG_DATA_HOME", "XDG_DATA_DIRS");
BASE_CONFIG_FILE = getEnvFilesWithDefault("~/.mcaselector", "mcaselector/settings.json", ':', "XDG_CONFIG_HOME", "XDG_CONFIG_DIRS");
BASE_OVERLAYS_FILE = getEnvFilesWithDefault("~/.mcaselector", "mcaselector/overlays.json", ':', "XDG_CONFIG_HOME", "XDG_CONFIG_DIRS");
BASE_CACHE_DIR = getFileFromPreferencedPaths("mcaselector", getEnvWithDefault("XDG_CACHE_HOME", "~/.cache"));
BASE_LOG_DIR = getFileFromPreferencedPaths("mcaselector/log", getEnvWithDefault("XDG_STATE_HOME", "~/.local/state"));
BASE_CONFIG_FILE = getFileFromPreferencedPaths("mcaselector/settings.json", getEnvWithDefault("XDG_CONFIG_HOME", "~/.config") + ":" + getEnvWithDefault("XDG_CONFIG_DIRS", "/etc/xdg"));
BASE_OVERLAYS_FILE = getFileFromPreferencedPaths("mcaselector/overlays.json", getEnvWithDefault("XDG_CONFIG_HOME", "~/.config") + ":" + getEnvWithDefault("XDG_CONFIG_DIRS", "/etc/xdg"));

}

if (!BASE_CACHE_DIR.exists()) {
Expand Down Expand Up @@ -94,6 +95,33 @@ private static File getEnvFilesWithDefault(String def, String suffix, char divid
throw new RuntimeException("failed to create directories for " + suffix + ", please check permissions for " + resolveHome(def));
}

private static File getFileFromPreferencedPaths(String suffix, String paths) {
File f;

String[] pathsArray = paths.split(":");
for (String path : pathsArray) {
f = new File(resolveHome(path), suffix);
if (f.exists()) {
return f;
}
}

f = new File(resolveHome(pathsArray[0]), suffix);
if (attemptCreateDirectory(f)) {
return f;
}
throw new RuntimeException("failed to create directories for " + suffix + ", please check permissions for " + resolveHome(pathsArray[0]));
}

private static String getEnvWithDefault(String env, String def) {
String systemValue = System.getenv(env);
if (systemValue != null && !systemValue.isEmpty()) {
return systemValue;
} else {
return def;
}
}

private static boolean attemptCreateDirectory(File file) {
File parent = file.getParentFile();
if (parent == null) {
Expand Down