Skip to content

Run query on Command-Enter #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

Run query on Command-Enter #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/components/App/ObservabilityQueryLanguageComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ export default function ObservabilityQueryLanguageComponent() {
}, []); // Add empty dependency array to run once

useEffect(() => {

setIsLoading(true);
setError(null);

Expand Down Expand Up @@ -164,9 +163,9 @@ export default function ObservabilityQueryLanguageComponent() {
}, []);

const runQuery = useCallback(() => {
setActiveQuery(query);
setActiveQuery(queryRef.current);
setQueryTimestamp(Date.now());
}, [query]);
}, [setActiveQuery, setQueryTimestamp]);

const handleGlyphClick = useCallback((lineNumber: number, isPlay: boolean) => {
const lines = queryRef.current.split('\n');
Expand Down Expand Up @@ -279,6 +278,10 @@ export default function ObservabilityQueryLanguageComponent() {
setShowAiModal(true);
}, []);

const handleQueryChange = useCallback((value: string) => {
setQuery(value);
}, [setQuery]);

return (
<div style={{ paddingLeft: '20px', paddingRight: '20px', paddingTop: '10px', colorScheme: 'dark' }}>
<h3><img src={logo} alt="Quesma Logo" style={{ height: '35px' }} /> - Observability Query Language</h3>
Expand Down Expand Up @@ -348,13 +351,14 @@ export default function ObservabilityQueryLanguageComponent() {

<Editor
query={query}
onChange={useCallback((value: string) => setQuery(value), [setQuery])}
onChange={handleQueryChange}
startDate={startDate}
endDate={endDate}
tableDefinitions={tableDefinitions}
tableName={currentTable}
onGlyphClick={handleGlyphClick}
onAiModalOpen={handleAiModalOpen}
onEnter={runQuery}
/>
</div>

Expand Down
5 changes: 3 additions & 2 deletions src/components/editor/Editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,14 +235,15 @@ export const Editor: React.FC<EditorProps> = ({ query, onChange, startDate, endD
return () => window.removeEventListener('mousemove', handleMouseMove);
}, []);

initPipeSQLLanguage();
useEffect(() => {
initPipeSQLLanguage();
}, []);

const handleEditorDidMount = (editor: monaco.editor.IStandaloneCodeEditor, monaco: typeof import('monaco-editor')) => {
editorRef.current = editor;

// Register language


// Add command for Ctrl/Cmd + Enter
editor.addCommand(monaco.KeyMod.CtrlCmd | monaco.KeyCode.Enter, () => {
if (onEnter) {
Expand Down
Loading