This repository was archived by the owner on Nov 7, 2025. It is now read-only.
Report errors in queries better #2 (in parsing bucket aggregations) #1006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trzysiek
force-pushed
the
report-errors-in-queries-better
branch
from
1e433b7 to
348e0fe
Compare
trzysiek
changed the title
Deploying quesma with
|
| Latest commit: |
0a07198
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9237ddaa.quesma.pages.dev |
| Branch Preview URL: | https://report-errors-in-queries-bet.quesma.pages.dev |
trzysiek
commented
Dec 11, 2024
Member
Author
There was a problem hiding this comment.
only very very minor style improvements in this file
trzysiek
force-pushed
the
report-errors-in-queries-better
branch
from
a2b9125 to
11e7c61
Compare
trzysiek
force-pushed
the
report-errors-in-queries-better
branch
from
11e7c61 to
d77bb30
Compare
trzysiek
force-pushed
the
report-errors-in-queries-better
branch
from
cde08d8 to
df02efd
Compare
trzysiek
changed the title
trzysiek
changed the title
trzysiek
requested review from
avelanarius,
jakozaur,
mieciu,
nablaone and
pdelewski
trzysiek
changed the title
jakozaur
approved these changes
Dec 12, 2024
| } else { | ||
| logger.WarnWithCtx(cw.Ctx).Msgf("format specified for date range aggregation is not a string. Using empty. Querymap: %v", dateRange) | ||
| } | ||
| func (cw *ClickhouseQueryTranslator) parseDateRangeAggregation(aggregation *pancakeAggregationTreeNode, params QueryMap) (err error) { |
Contributor
There was a problem hiding this comment.
I wonder about type signature? Why pass aggregation as argument, shouldn't we just return optional queryType?
Contributor
There was a problem hiding this comment.
Ok, after reading later it become obvious why you did that way.
| filtersAggr = bucket_aggregations.NewFiltersEmpty(cw.Ctx) | ||
|
|
||
| filtersRaw, exists := queryMap["filters"] | ||
| func (cw *ClickhouseQueryTranslator) parseFilters(aggregation *pancakeAggregationTreeNode, params QueryMap) error { |
Contributor
There was a problem hiding this comment.
Similar, here. Not sure if it's right to pass aggregation here.
Contributor
There was a problem hiding this comment.
Ok, I understand. It explain later. Keep as ai.
| return false, fmt.Errorf("histogram is not a map, but %T, value: %v", histogramRaw, histogramRaw) | ||
| } | ||
| func (cw *ClickhouseQueryTranslator) pancakeTryBucketAggregation(aggregation *pancakeAggregationTreeNode, queryMap QueryMap) error { | ||
| aggregationHandlers := []struct { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old comment (motivation):
Our error messages for errors encountered while parsing query request isn't as good as Elastic's, I'll try to improve it here. (It's not that unimportant, with invalid query request where Elastic always fails with an error response, we often don't and e.g. return empty results, which might trick the user that queries went fine)
I think I'll split it into few PRs. This might be a good starting point for another one. (update: actually similar small improvement was already merged, but for pipeline aggregations)
new comment (what's been done):
There's really not much going on here.
Clue of this PR is to change our very ugly 400-line
func (cw *ClickhouseQueryTranslator) pancakeTryBucketAggregationfunction into something a bit nicer. And also report errors in more places, to be consistent with Elastic's behaviour.Quite a few style improvements that I automatically caught in the process, but only some trivial/very local ones, so extracting copy/paste used 5 times into 1 function, consistent naming across parsers of different aggregations, etc. (not much more).