Skip to content
This repository was archived by the owner on Nov 7, 2025. It is now read-only.

Unskip 1 test which works #1011

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Unskip 1 test which works #1011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions quesma/queryparser/pancake_sql_query_generation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,6 @@ func TestPancakeQueryGeneration(t *testing.T) {
t.Skip("Need to implement order by top metrics (talk with Jacek, he has an idea)")
}

if test.TestName == "multiple buckets_path(file:clients/clover,nr:1)" {
t.Skip("This needs fixing ASAP, easy to fix")
}

if test.TestName == "max_bucket. Reproduce: Visualize -> Line: Metrics: Max Bucket (Bucket: Filters, Metric: Sum)(file:opensearch-visualize/pipeline_agg_req,nr:20)" ||
test.TestName == "complex max_bucket. Reproduce: Visualize -> Line: Metrics: Max Bucket (Bucket: Filters, Metric: Sum), Buckets: Split chart: Rows -> Range(file:opensearch-visualize/pipeline_agg_req,nr:21)" {
t.Skip("Was skipped before. Wrong key in max_bucket, should be an easy fix")
Expand Down
25 changes: 16 additions & 9 deletions quesma/testdata/clients/clover.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,12 +231,13 @@ var CloverTests = []testdata.AggregationTestCase{
"field": "@timestamp"
},
"meta": {
"indexPatternString": "ab*",
"intervalString": "900000ms",
"dataViewId": "d3d7af60-4c81-11e8-b3d7-01146121b73d",
"indexPatternString": "kibana_sample_data_flights",
"intervalString": "54000000ms",
"normalized": true,
"panelId": "0",
"seriesId": "1",
"timeField": "@timestamp"
"panelId": "1a1d745d-0c21-4103-a2ae-df41d4fbd366",
"seriesId": "866fb08f-b9a4-43eb-a400-38ebb6c13aed",
"timeField": "timestamp"
}
}
},
Expand Down Expand Up @@ -298,14 +299,20 @@ var CloverTests = []testdata.AggregationTestCase{
"buckets": [
{
"a2": {
"value": 202.0
"value": 1
},
"a2-denominator": {
"doc_count": 202
},
"a2-numerator": {
"doc_count": 202
},
"doc_count": 202,
"key": 1728518400000,
"key_as_string": "2024-10-10T00:00:00.000Z"
"key": 1728640683723,
"key_as_string": "2024-10-11T09:58:03.723"
}
],
"interval": "7d",
"interval": "100y",
"meta": {
"dataViewId": "d3d7af60-4c81-11e8-b3d7-01146121b73d",
"indexPatternString": "kibana_sample_data_flights",
Expand Down
Loading