This repository was archived by the owner on Nov 7, 2025. It is now read-only.
Replace all target configurations with new variant
#1015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelanarius
requested review from
jakozaur,
mieciu,
nablaone,
pdelewski and
trzysiek
avelanarius
force-pushed
the
new-targets-everywhere
branch
from
fc26680 to
d907c3c
Compare
In QuesmaOrg#945, a new ("extended") target configuration was introduced: target: - a - b instead of "target: [a, b]". We still maintain compatibility with the old target configuration. However, we should educate users (in our docs) to use the new target configuration. This PR replaces all, internal and external (docs), uses of old target configuration with the new ("extended") target configuration. A new test (TestTargetLegacyVariant) is added to make sure we still maintain compatibility with the old way of declaring targets.
avelanarius
force-pushed
the
new-targets-everywhere
branch
from
d907c3c to
2de0d2f
Compare
pdelewski
approved these changes
Nov 20, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
In #945, a new ("extended") target configuration was introduced: ```yaml target: - a - b ``` instead of `target: [a, b]`. We still maintain compatibility with the old target configuration. However, we should educate users (in our docs) to use the new target configuration. This PR replaces all, internal and external (docs), uses of old target configuration with the new ("extended") target configuration. A new test (`TestTargetLegacyVariant`) is added to make sure we still maintain compatibility with the old way of declaring targets.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #945, a new ("extended") target configuration was introduced:
instead of
target: [a, b].We still maintain compatibility with the old target configuration. However, we should educate users (in our docs) to use the new target configuration.
This PR replaces all, internal and external (docs), uses of old target configuration with the new ("extended") target configuration. A new test (
TestTargetLegacyVariant) is added to make sure we still maintain compatibility with the old way of declaring targets.