This repository was archived by the owner on Nov 7, 2025. It is now read-only.
Fix SchemaToColumns for geo_point types, add ingest integration tests
#1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a geo_point field is added to fieldEncodings, actually two fields get added: - my_field.lat - my_field.lon SchemaToColumns however tried to find "my_field" in fieldEncodings (which was missing; only "my_field.lat" and "my_field.lon" was there) which resulted in creating (unused) columns "lat", "lon" since internalPropertyName was empty. Fix the problem by accessing "my_field.lat" and "my_field.lon" keys in fieldEncodings instead (which should be there).
avelanarius
requested review from
jakozaur,
mieciu,
nablaone,
pdelewski and
trzysiek
avelanarius
changed the title
SchemaToColumns for geo_point types, add ingest integration tests
Member
Author
|
Integration tests passed: https://github.com/QuesmaOrg/quesma/actions/runs/11937331599 |
pdelewski
approved these changes
Nov 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
geo_pointfield is added tofieldEncodings, actually two fields get added:my_field.latmy_field.lonSchemaToColumnshowever tried to findmy_fieldinfieldEncodings(which was missing; onlymy_field.latandmy_field.lonwere there). This resulted in creating (incorrect, unused) columnslat,lonsinceinternalPropertyNamewas empty.Fix the problem by accessing
my_field.latandmy_field.lonkeys infieldEncodingsinstead (which should be there).Add new integration test that checks Quesma's ingest of Kibana sample flights, Kibana sample ecommerce. The tests without "PUT mapping" caught the fixed issue (this is how I found it).