This repository was archived by the owner on Nov 7, 2025. It is now read-only.
[sample_logs] Treat leaf filter as metric, not bucket aggregation
#1317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying quesma with
|
| Latest commit: |
d47bbac
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://32e7415b.quesma.pages.dev |
| Branch Preview URL: | https://sample-logs-2.quesma.pages.dev |
Member
Author
|
/run-integration-tests |
Member
Author
|
/run-integration-tests |
Member
Author
|
/run-integration-tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncomments 2 tests and fixes 2 last TODO requests from the
sample_logsdashboard.Leaf filter is basically a metric, even a very simple one, response always looks like this:
{"doc_count": 12}. It seems reasonable to me to treat it as a metric.Works, but maybe let me try to refactor the code a bit. Now it's a hackish solution.
Edit: I changed my mind. If we release tomorrow (Wednesday) morning, why not do it with a few more panels on sample dashboards working. Code doesn't look that bad to me and we can polish it afterwards. That's the version I showed today - almost everything works on all samples.