Skip to content
This repository was archived by the owner on Nov 7, 2025. It is now read-only.

Conversation

@trzysiek
Copy link
Member

@trzysiek trzysiek commented Mar 3, 2025

Casting to simple Float is dangerous, as the column can be Nullable(Float), and Clickhouse panics. It's also unnecessary, as we stopped keeping geo as Strings.

Gets rid of

Error processing request: clickhouse: iterating over rows failed:  code: 349, message:
Cannot convert NULL value to non-Nullable type: while executing
'FUNCTION CAST(__table1.geoip_location_lat :: 1, 'Float'_String : 9) -> CAST(__table1.geoip_location_lat, 'Float'_String) Float32 : 12'	

@trzysiek trzysiek marked this pull request as ready for review March 4, 2025 10:37
@trzysiek trzysiek requested a review from a team as a code owner March 4, 2025 10:37
@trzysiek
Copy link
Member Author

trzysiek commented Mar 4, 2025

/run-integration-tests

@trzysiek trzysiek enabled auto-merge March 4, 2025 10:58
@trzysiek trzysiek added this pull request to the merge queue Mar 4, 2025
Merged via the queue into main with commit 3b79092 Mar 4, 2025
5 of 6 checks passed
@trzysiek trzysiek deleted the quickfix-flights-2 branch March 4, 2025 11:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants