Skip to content
This repository was archived by the owner on Nov 7, 2025. It is now read-only.

Take local platform dependency #1348

Merged
merged 10 commits into from
Mar 5, 2025
Merged

Take local platform dependency #1348

merged 10 commits into from
Mar 5, 2025

Conversation

@pdelewski
Copy link
Contributor

@pdelewski pdelewski commented Mar 4, 2025

No description provided.

@mieciu mieciu marked this pull request as ready for review March 5, 2025 11:51
@mieciu mieciu requested a review from a team as a code owner March 5, 2025 11:51
@mieciu
Copy link
Member

mieciu commented Mar 5, 2025

/run-integration-tests

@mieciu
Copy link
Member

mieciu commented Mar 5, 2025 •
edited
Loading

~Failure in that triggered IT run was expected since it has used job definitions from main, here's a "legally binding" run https://github.com/QuesmaOrg/quesma/actions/runs/13675389549 😉 ~ ugh it won't work that way - we'll have to merge and then work on that

mieciu
mieciu approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@mieciu mieciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve.

@mieciu mieciu enabled auto-merge March 5, 2025 11:59
@mieciu mieciu disabled auto-merge March 5, 2025 11:59
@mieciu mieciu enabled auto-merge March 5, 2025 11:59
@mieciu mieciu disabled auto-merge March 5, 2025 12:03
@mieciu mieciu merged commit d1aa8b5 into main Mar 5, 2025
6 of 9 checks passed
@mieciu mieciu deleted the take-local-platform-dep branch March 5, 2025 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nablaone nablaone Awaiting requested review from nablaone nablaone is a code owner automatically assigned from QuesmaOrg/engineering

@jakozaur jakozaur Awaiting requested review from jakozaur jakozaur is a code owner automatically assigned from QuesmaOrg/engineering

@stared stared Awaiting requested review from stared stared is a code owner automatically assigned from QuesmaOrg/engineering

@trzysiek trzysiek Awaiting requested review from trzysiek trzysiek is a code owner automatically assigned from QuesmaOrg/engineering

1 more reviewer

@mieciu mieciu mieciu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pdelewski @mieciu