This repository was archived by the owner on Nov 7, 2025. It is now read-only.
Refactor towards better table creation #1439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakozaur
requested review from
avelanarius,
mieciu,
nablaone,
stared and
trzysiek
Contributor
|
@jakozaur That's the first step?, if I understand correctly |
Contributor
Author
|
@pdelewski Yes, there is more refactoring. Though decided step by step approach is better. |
pdelewski
approved these changes
Jun 4, 2025
Contributor
Author
|
/run-it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our logic of parsing
CREATE TABLEneeds to be replaced. This is code duplication and a potential issue.First steps:
Created. It is not used now, it is artifact from legacy hardcoding table.