This repository was archived by the owner on Nov 7, 2025. It is now read-only.
String column as keyword field #1444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nablaone
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a new stringColumnIsKeywordField flag that controls whether string columns are exposed as keyword (instead of text) in legacy configs and clickhouse type adapter.
- Introduce
StringColumnIsKeywordFieldin v2 config, translation, and legacy config - Wire the flag through
SchemaTypeAdapterto returnQuesmaTypeKeywordfor"String"when set - Add tests for default and enabled behaviors and a sample YAML config
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| platform/config/test_configs/string_column_is_keyword_field.yaml | New test config enabling the flag |
| platform/config/config_v2_test.go | Tests for default (false) and enabled (true) flag translation |
| platform/config/config_v2.go | Added StringColumnIsKeywordField to v2 struct and translation |
| platform/config/config.go | Added flag to legacy config struct and config print output |
| platform/clickhouse/type_adapter.go | New SchemaTypeAdapter that respects the flag when converting types |
| cmd/main.go | Pass flag into NewSchemaTypeAdapter |
| cmd/experimental/main.go | Same wiring in experimental main |
Comments suppressed due to low confidence (2)
platform/config/config_v2.go:52
- [nitpick] Add a comment above this field explaining its purpose, default value (false), and how it affects downstream behavior to keep configuration docs in sync.
StringColumnIsKeywordField bool `koanf:"stringColumnIsKeywordField"`
platform/clickhouse/type_adapter.go:33
- Add unit tests for
SchemaTypeAdapter.Convertcovering both flag conditions (true and false) so that the new keyword/text behavior is validated.
case "String":
Member
Author
|
/run-it |
jakozaur
suggested changes
Jun 5, 2025
Contributor
jakozaur
left a comment
jakozaur
left a comment
There was a problem hiding this comment.
Good, but please change configuration name.
platform/config/config_v2.go
Outdated
| Pipelines []Pipeline `koanf:"pipelines"` | ||
| DisableTelemetry bool `koanf:"disableTelemetry"` | ||
| MapFieldsDiscoveringEnabled bool `koanf:"mapFieldsDiscoveringEnabled"` | ||
| StringColumnIsKeywordField bool `koanf:"stringColumnIsKeywordField"` |
Contributor
There was a problem hiding this comment.
Do not like this name.
For example better suggestion:
defaultStringToKeywordType
Member
Author
|
/run-it |
jakozaur
approved these changes
Jun 6, 2025
Member
Author
|
Added an extra struct for aux flags. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quesma exposes
Stringcolumns as text type fields. This is the default behaviour. When a user performs a full-text search, quesma searches through all text fields. It can lead to massive queries.This PR adds a flag that changes the default type.