This repository was archived by the owner on Nov 7, 2025. It is now read-only.
Lack of schema refresh after new field in common table #1461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakozaur
reviewed
Jun 12, 2025
| assert.Equal(t, http.StatusOK, resp.StatusCode) | ||
|
|
||
| // wait for internal processing, especially for the periodic task that updates the schema | ||
| time.Sleep(60 * time.Second) |
Contributor
There was a problem hiding this comment.
Ok, this is very tricky to add. Slow IT are hard to debug and takes a lot to some engineering.
Member
Author
There was a problem hiding this comment.
Yes. I know.
I will add an endpoint to reload tables.
Member
Author
There was a problem hiding this comment.
Changed the test. Added endpoint. And fixed "eventually consistent" index that keeps a list of virtual tables.
Member
Author
|
/run-it |
1 similar comment
Member
Author
|
/run-it |
jakozaur
approved these changes
Jun 12, 2025
Contributor
jakozaur
left a comment
jakozaur
left a comment
There was a problem hiding this comment.
Can be merged, but move it to admin interface.
| func (a *OnlyCommonTableTestcase) testAlterVirtualTable(ctx context.Context, t *testing.T) { | ||
|
|
||
| reloadTables := func() { | ||
| resp, body := a.RequestToQuesma(ctx, t, "POST", "/_quesma/reload-tables", nil) |
Contributor
There was a problem hiding this comment.
We should put that method under our admin port, not on ElasticSearch frontend.
As we are rushing with release fine to do in next PR.
| return &quesma_api.Result{Body: string(body), StatusCode: http.StatusOK, GenericResult: body}, nil | ||
| }) | ||
|
|
||
| router.Register(routes.QuesmaReloadTablsPath, method("POST"), func(ctx context.Context, req *quesma_api.Request, _ http.ResponseWriter) (*quesma_api.Result, error) { |
Contributor
There was a problem hiding this comment.
As above, please move this to admin interface.
nablaone
deleted the
que-246-lack-of-schema-refresh-after-new-field-in-common-table
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quesma relies on
attributescolumns when it calculates the schema change on ingest. Table discovery didn't add these fields to virtual tables. Therefore, the schema of the index stored in thecommon tablebecomes immutable within 60 seconds.