This repository was archived by the owner on Nov 7, 2025. It is now read-only.
Fix: 409 on storing virtual table definition #1469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nablaone
requested review from
avelanarius,
cezpiw,
Copilot,
jakozaur,
pdelewski and
stared
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates how virtual table definitions are stored in Elasticsearch by switching from the _update endpoint with upsert logic to the _doc endpoint using PUT, eliminating 409 conflicts on writes.
- Change write URL from
/_update/{id}to/_doc/{id} - Remove JSON upsert wrapper and simplify payload to the
Wrapperstruct - Switch HTTP method from
POSTtoPUTfor document creation/replacement
Comments suppressed due to low confidence (1)
platform/persistence/elastic.go:62
- Add unit tests for the new PUT _doc behavior to verify that documents are created or replaced correctly and that 409 conflicts no longer occur.
elasticsearchURL := fmt.Sprintf("%s/_doc/%s", p.indexName, key)
| } | ||
|
|
||
| resp, err := p.httpClient.Request(context.Background(), "POST", elasticsearchURL, jsonData) | ||
| resp, err := p.httpClient.Request(context.Background(), "PUT", elasticsearchURL, jsonData) |
There was a problem hiding this comment.
The response status is not checked after the request. Consider verifying resp.StatusCode for non-2xx values and returning an error for unexpected statuses to surface server-side failures.
Member
Author
There was a problem hiding this comment.
It's checked in line 77. Please review again.
pdelewski
approved these changes
Jun 18, 2025
nablaone
deleted the
que-275-error-storing-virtual-table-failed-to-elastic-409-conflict
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the method by which we store virtual table definitions in Elasticsearch. It fixes 409 errors that can occur during write.