This repository was archived by the owner on Nov 7, 2025. It is now read-only.
/:idx/_count works now with indexes stored in quesma_common_table #1494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/run-it |
trzysiek
commented
Jul 11, 2025
Comment on lines
+349
to
+352
| func (lm *LogManager) IsInTransparentProxyMode() bool { | ||
| return lm.cfg.TransparentProxy | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
moved up so all methods are grouped together
trzysiek
commented
Jul 12, 2025
Comment on lines
-154
to
+156
| func executeQuery(ctx context.Context, lm *LogManager, query *model.Query, fields []string, rowToScan []interface{}) (res []model.QueryResultRow, performanceResult PerformanceResult, err error) { | ||
| func executeQuery(ctx context.Context, lm *LogManager, query *model.Query, fields []string, rowToScan []interface{}) ( | ||
| res []model.QueryResultRow, performanceResult PerformanceResult, err error) { | ||
|
|
Member
Author
There was a problem hiding this comment.
broke down this and a few other lines to make them fit in 1 line on laptop
trzysiek
commented
Jul 12, 2025
Comment on lines
-107
to
-114
| func PrettyJson(jsonStr string) string { | ||
| var prettyJSON bytes.Buffer | ||
| if err := json.Indent(&prettyJSON, []byte(jsonStr), "", " "); err != nil { | ||
| return fmt.Sprintf("PrettyJson err: %v\n", err) | ||
| } | ||
| return prettyJSON.String() | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
unused, we have better one already
Member
Author
|
/run-it |
trzysiek
force-pushed
the
1241-count-common-table
branch
from
3bd4481 to
4f7bfc1
Compare
trzysiek
force-pushed
the
1241-count-common-table
branch
from
4f7bfc1 to
bc3572a
Compare
Member
Author
|
/run-it |
Member
Author
|
/run-it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to fix #1241
Added some tests for it + here screens of a manual test
