Skip to content
This repository was archived by the owner on Nov 7, 2025. It is now read-only.

Use backquote for table and column names #1500

Closed
wants to merge 5 commits into from
Closed

Use backquote for table and column names #1500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
83820c8
BackquoteIdentifier
DongLiang-0 Jul 16, 2025
a920790
fix test case
DongLiang-0 Jul 22, 2025
36c903e
fix
DongLiang-0 Jul 22, 2025
fee092c
fix
DongLiang-0 Jul 22, 2025
972922b
fix
DongLiang-0 Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bin/unjson-dashboards/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,14 @@ github.com/k0kubun/colorstring v0.0.0-20150214042306-9440f1994b88 h1:uC1QfSlInpQ
github.com/k0kubun/colorstring v0.0.0-20150214042306-9440f1994b88/go.mod h1:3w7q1U84EfirKl04SVQ/s7nPm1ZPhiXd34z40TNz36k=
github.com/k0kubun/pp v3.0.1+incompatible h1:3tqvf7QgUnZ5tXO6pNAZlrvHgl6DvifjDrd9g2S9Z40=
github.com/k0kubun/pp v3.0.1+incompatible/go.mod h1:GWse8YhT0p8pT4ir3ZgBbfZild3tgzSScAn6HmfYukg=
github.com/ledongthuc/pdf v0.0.0-20220302134840-0c2507a12d80/go.mod h1:imJHygn/1yfhB7XSJJKlFZKl/J+dCPAknuiaGOshXAs=
github.com/mailru/easyjson v0.9.0 h1:PrnmzHw7262yW8sTBwxi1PdJA3Iw/EKBa8psRf7d9a4=
github.com/mailru/easyjson v0.9.0/go.mod h1:1+xMtQp2MRNVL/V1bOzuP3aP8VNwRW55fQUto+XFtTU=
github.com/mattn/go-colorable v0.1.14 h1:9A9LHSqF/7dyVVX6g0U9cwm9pG3kP9gSzcuIPHPsaIE=
github.com/mattn/go-colorable v0.1.14/go.mod h1:6LmQG8QLFO4G5z1gPvYEzlUgJ2wF+stgPZH1UqBm1s8=
github.com/mattn/go-isatty v0.0.20 h1:xfD0iDuEKnDkl03q4limB+vH+GxLEtL/jb4xVJSWWEY=
github.com/mattn/go-isatty v0.0.20/go.mod h1:W+V8PltTTMOvKvAeJH7IuucS94S2C6jfK/D7dTCTo3Y=
github.com/orisano/pixelmatch v0.0.0-20220722002657-fb0b55479cde/go.mod h1:nZgzbfBr3hhjoZnS66nKrHmduYNpc34ny7RK4z5/HM0=
golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
golang.org/x/sys v0.29.0 h1:TPYlXGxvx1MGTn2GiZDhnjPA9wZzZeGKHHmKhHYvgaU=
golang.org/x/sys v0.29.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
115 changes: 115 additions & 0 deletions ci/it/go.sum
View file
Open in desktop

Large diffs are not rendered by default.

217 changes: 217 additions & 0 deletions cmd/experimental/go.sum
View file
Open in desktop

Large diffs are not rendered by default.

218 changes: 218 additions & 0 deletions cmd/go.sum
View file
Open in desktop

Large diffs are not rendered by default.

19 changes: 9 additions & 10 deletions platform/frontend_connectors/search_common_table_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ func TestSearchCommonTable(t *testing.T) {
Rows []*sqlmock.Rows
IndexPattern string
}{

{ // [0]
Name: "query non virtual table",
IndexPattern: "logs-3",
Expand All @@ -43,7 +42,7 @@ func TestSearchCommonTable(t *testing.T) {
}
}`,
WantedSql: []string{
`SELECT "@timestamp", "message" FROM "logs-3" LIMIT 10`,
"SELECT `@timestamp`, `message` FROM `logs-3` LIMIT 10",
},
},

Expand All @@ -60,7 +59,7 @@ func TestSearchCommonTable(t *testing.T) {
}
}`,
WantedSql: []string{
`SELECT "@timestamp", "message" FROM quesma_common_table WHERE "__quesma_index_name"='logs-1' LIMIT 10`,
"SELECT `@timestamp`, `message` FROM `quesma_common_table` WHERE `__quesma_index_name`='logs-1' LIMIT 10",
},
},

Expand All @@ -77,7 +76,7 @@ func TestSearchCommonTable(t *testing.T) {
}
}`,
WantedSql: []string{
`SELECT "@timestamp", "message", "__quesma_index_name" FROM quesma_common_table WHERE ("__quesma_index_name"='logs-1' OR "__quesma_index_name"='logs-2') LIMIT 10`,
"SELECT `@timestamp`, `message`, `__quesma_index_name` FROM `quesma_common_table` WHERE (`__quesma_index_name`='logs-1' OR `__quesma_index_name`='logs-2') LIMIT 10",
},
},

Expand All @@ -94,7 +93,7 @@ func TestSearchCommonTable(t *testing.T) {
}
}`,
WantedSql: []string{
`SELECT "@timestamp", "message", "__quesma_index_name" FROM quesma_common_table WHERE ("__quesma_index_name"='logs-1' OR "__quesma_index_name"='logs-2') LIMIT 10`,
"SELECT `@timestamp`, `message`, `__quesma_index_name` FROM `quesma_common_table` WHERE (`__quesma_index_name`='logs-1' OR `__quesma_index_name`='logs-2') LIMIT 10",
},
},

Expand All @@ -111,7 +110,7 @@ func TestSearchCommonTable(t *testing.T) {
}
}`,
WantedSql: []string{
`SELECT "@timestamp", "message", "__quesma_index_name" FROM quesma_common_table WHERE startsWith("__quesma_index_name",'daily-') LIMIT 10`,
"SELECT `@timestamp`, `message`, `__quesma_index_name` FROM `quesma_common_table` WHERE startsWith(`__quesma_index_name`,'daily-') LIMIT 10",
},
},

Expand All @@ -128,7 +127,7 @@ func TestSearchCommonTable(t *testing.T) {
}
}`,
WantedSql: []string{
`SELECT "@timestamp", "message", "__quesma_index_name" FROM quesma_common_table WHERE ("__quesma_index_name"='logs-1' OR "__quesma_index_name"='logs-2') LIMIT 10`,
"SELECT `@timestamp`, `message`, `__quesma_index_name` FROM `quesma_common_table` WHERE (`__quesma_index_name`='logs-1' OR `__quesma_index_name`='logs-2') LIMIT 10",
},
},

Expand All @@ -145,7 +144,7 @@ func TestSearchCommonTable(t *testing.T) {
}
}`,
WantedSql: []string{
`SELECT "@timestamp", "message", "__quesma_index_name" FROM quesma_common_table WHERE ("__quesma_index_name"='logs-1' OR "__quesma_index_name"='logs-2') LIMIT 10`,
"SELECT `@timestamp`, `message`, `__quesma_index_name` FROM `quesma_common_table` WHERE (`__quesma_index_name`='logs-1' OR `__quesma_index_name`='logs-2') LIMIT 10",
},
},

Expand Down Expand Up @@ -185,8 +184,8 @@ func TestSearchCommonTable(t *testing.T) {
}
}`,
WantedSql: []string{
`SELECT countIf("@timestamp"<toInt64(toUnixTimestamp(now()))) AS "range_0__aggr__2__count", countIf(("@timestamp">=toInt64(toUnixTimestamp(toStartOfDay(subDate(now(), INTERVAL 3 week)))) AND "@timestamp"<toInt64(toUnixTimestamp(now())))) AS "range_1__aggr__2__count", countIf("@timestamp">=toInt64(toUnixTimestamp('2024-04-14'))) AS "range_2__aggr__2__count" FROM quesma_common_table WHERE ("__quesma_index_name"='logs-1' OR "__quesma_index_name"='logs-2') -- optimizations: pancake(half)`,
`SELECT "@timestamp", "message", "__quesma_index_name" FROM quesma_common_table WHERE ("__quesma_index_name"='logs-1' OR "__quesma_index_name"='logs-2') LIMIT 10`,
"SELECT countIf(`@timestamp`<toInt64(toUnixTimestamp(now()))) AS `range_0__aggr__2__count`, countIf((`@timestamp`>=toInt64(toUnixTimestamp(toStartOfDay(subDate(now(), INTERVAL 3 week)))) AND `@timestamp`<toInt64(toUnixTimestamp(now())))) AS `range_1__aggr__2__count`, countIf(`@timestamp`>=toInt64(toUnixTimestamp('2024-04-14'))) AS `range_2__aggr__2__count` FROM `quesma_common_table` WHERE (`__quesma_index_name`='logs-1' OR `__quesma_index_name`='logs-2') -- optimizations: pancake(half)",
"SELECT `@timestamp`, `message`, `__quesma_index_name` FROM `quesma_common_table` WHERE (`__quesma_index_name`='logs-1' OR `__quesma_index_name`='logs-2') LIMIT 10",
},
// we need to return some rows, otherwise pancakes will fail
Rows: []*sqlmock.Rows{
Expand Down
Loading
Loading