This repository was archived by the owner on Nov 7, 2025. It is now read-only.
Adapt to string type time data #1501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongLiang-0
requested review from
cezpiw,
jakozaur,
nablaone,
pdelewski and
stared
pdelewski
reviewed
Jul 23, 2025
|
|
||
| func (query *DateHistogram) getKey(row model.QueryResultRow) int64 { | ||
| return row.Cols[len(row.Cols)-2].Value.(int64) | ||
| value := row.Cols[len(row.Cols)-2].Value |
pdelewski
suggested changes
Jul 23, 2025
Contributor
pdelewski
left a comment
pdelewski
left a comment
There was a problem hiding this comment.
Seems that these 2 functions are the same. Please extract one helper function and use it in both places
pdelewski
approved these changes
Jul 23, 2025
Contributor
|
/run-it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the data is converted into string type in the data reading of doris, we need to process the string type specifically here.
Related PR: https://github.com/QuesmaOrg/quesma/blob/main/platform/database_common/quesma_communicator.go#L228