Skip to content
This repository was archived by the owner on Nov 7, 2025. It is now read-only.

Conversation

@pdelewski
Copy link
Contributor

@pdelewski pdelewski commented Jul 31, 2025

This PR introduces an abstract logical __quesma_date_hour function to be used at the parsing level, and adds a new DateTimeFunction transformation that lowers it to a backend-specific implementation.

@pdelewski pdelewski force-pushed the datetime-doris-transformation branch from 5dda4ec to 1e553b2 Compare July 31, 2025 13:28
@pdelewski
Copy link
Contributor Author

/run-it

@pdelewski pdelewski marked this pull request as ready for review July 31, 2025 13:48
@pdelewski pdelewski requested a review from a team as a code owner July 31, 2025 13:48
Copy link
Member

@nablaone nablaone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one readability note. Overall LGTM

@pdelewski pdelewski added this pull request to the merge queue Jul 31, 2025
Merged via the queue into main with commit 40ac249 Jul 31, 2025
7 checks passed
@pdelewski pdelewski deleted the datetime-doris-transformation branch July 31, 2025 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants