This repository was archived by the owner on Nov 7, 2025. It is now read-only.
Licenses fix #1515
Merged
Licenses fix #1515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdelewski
approved these changes
Aug 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our internal dependency (
github.com/QuesmaOrg/quesma/platform) has been failing theNOTICE.MDgeneration job after we dissectedcmdandplatformmodules. Since it's our internal dependency (separate module) under Elastic 2.0 license andgo-license-detectorwas not able to figure out license type based on license file in the module directory, I had to work this around by creating "phantom" license type ofQUESMA_CODEBASE_UNDER_ELASTIC_2.0_LICENSEand put it in license allowlist.We did not wanted to have SPDX-compliant
Elastic-2.0license name in our allowlist as we don't want any of the dependencies using this type of license.