Skip to content
This repository was archived by the owner on Nov 7, 2025. It is now read-only.

Avoid mixed receivers. #818

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Avoid mixed receivers. #818

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0a3001
Avoid mixed receivers.
nablaone Sep 30, 2024
f1a2e5c
Merge branch 'main' into pr-select-command-receiver
nablaone Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions quesma/model/select.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ func (c SelectCommand) Accept(v ExprVisitor) interface{} {
return v.VisitSelectCommand(c)
}

func (c *SelectCommand) String() string {
func (c SelectCommand) String() string {
// TODO - we might need to verify queries nested N-times (N>=3), perhaps this should strip the outermost braces
return AsString(c)
}

func (c *SelectCommand) IsWildcard() bool {
func (c SelectCommand) IsWildcard() bool {
for _, col := range c.Columns {
if col == NewWildcardExpr {
return true
Expand All @@ -58,7 +58,7 @@ func (c *SelectCommand) IsWildcard() bool {
// only returns Order By columns, which are "tableColumn ASC/DESC",
// won't return complex ones, like e.g. toInt(int_field / 5).
// but it was like that before the refactor
func (c *SelectCommand) OrderByFieldNames() (fieldNames []string) {
func (c SelectCommand) OrderByFieldNames() (fieldNames []string) {
for _, expr := range c.OrderBy {
for _, colRefs := range GetUsedColumns(expr) {
fieldNames = append(fieldNames, colRefs.ColumnName)
Expand Down