This repository was archived by the owner on Nov 7, 2025. It is now read-only.
Persistent storage for asyncs 3 #895
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying quesma with
|
| Latest commit: |
161407b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4834cc4b.quesma.pages.dev |
| Branch Preview URL: | https://persistent-storage-2.quesma.pages.dev |
elszon
reviewed
Nov 6, 2024
trzysiek
force-pushed
the
persistent-storage-2
branch
from
61e367a to
29679c3
Compare
trzysiek
force-pushed
the
persistent-storage-2
branch
from
4ff28a1 to
576b195
Compare
trzysiek
force-pushed
the
persistent-storage-2
branch
4 times, most recently
from
61b7a7d to
76035ad
Compare
trzysiek
force-pushed
the
persistent-storage-2
branch
from
76035ad to
47229e0
Compare
trzysiek
requested review from
avelanarius,
jakozaur,
mieciu,
nablaone and
pdelewski
nablaone
reviewed
Feb 10, 2025
| } | ||
|
|
||
| var resp *http.Response | ||
| resp, err = db.httpClient.DoRequestCheckResponseStatusOK(context.Background(), http.MethodPost, elasticsearchURL, []byte(query)) |
Member
There was a problem hiding this comment.
404 is OK here, but we got:
quesma-1 | Feb 10 15:06:59.942 WRN quesma/quesma/async_search_storage/in_elasticsearch.go:72 > failed to delete old documents error="response code from Elastic is not 200 OK, but 404 Not Found"
| return err | ||
| } | ||
|
|
||
| resp, err := db.httpClient.DoRequestCheckResponseStatusOK(context.Background(), http.MethodPost, elasticsearchURL, jsonData) |
|
|
||
| func (db *ElasticDatabaseWithEviction) Delete(id string) error { | ||
| elasticsearchURL := fmt.Sprintf("%s/_doc/%s", db.indexName, id) | ||
| resp, err := db.httpClient.DoRequestCheckResponseStatusOK(context.Background(), http.MethodDelete, elasticsearchURL, nil) |
| fmt.Println(query) | ||
| } | ||
|
|
||
| var resp *http.Response |
| }` | ||
|
|
||
| var resp *http.Response | ||
| resp, err = db.httpClient.DoRequestCheckResponseStatusOK(context.Background(), http.MethodGet, elasticsearchURL, []byte(query)) |
| SizeInBytes() (int64, error) | ||
| SizeInBytesLimit() int64 | ||
| } | ||
| JSONWithSize struct { |
Member
There was a problem hiding this comment.
JSONWithSize is JSON with ID. This can be named Document
|
|
||
| func (s AsyncRequestResultStorageInMemoryFallbackElastic) Delete(id string) { | ||
| s.inMemory.Delete(id) | ||
| go s.inElasticsearch.Delete(id) |
Member
There was a problem hiding this comment.
This is risky. If there is a panic insidea s.inElasticsearch.Delete(#) whole Quesma will collapse.
We should add a recovery here:
go func() {
recovery.LogPanic()
s.inElasticsearch.Delete(id)
}()
This can called without a goroutine.
|
|
||
| func (s AsyncRequestResultStorageInMemoryFallbackElastic) evict(olderThan time.Duration) { | ||
| s.inMemory.evict(olderThan) | ||
| go s.inElasticsearch.DeleteOld(olderThan) |
|
|
||
| func (s AsyncQueryContextStorageInMemoryFallbackElasticsearch) Store(context *AsyncQueryContext) { | ||
| s.inMemory.Store(context) | ||
| go s.inElasticsearch.Store(context) |
|
|
||
| func (s AsyncQueryContextStorageInMemoryFallbackElasticsearch) evict(evictOlderThan time.Duration) { | ||
| s.inMemory.evict(evictOlderThan) | ||
| go s.inElasticsearch.evict(evictOlderThan) |
Member
|
@trzysiek please take a look, |
Contributor
|
/run-it |
2 similar comments
Contributor
|
/run-it |
Contributor
|
/run-it |
trzysiek
force-pushed
the
persistent-storage-2
branch
from
e136961 to
161407b
Compare
Member
Author
|
/run-it |
Contributor
|
I ran some tests, and unfortunately, it doesn’t work reliably. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On old Kibana I don't see any regression with new storage on.