This repository was archived by the owner on Nov 7, 2025. It is now read-only.
Add integration tests for new "*" configurations #913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelanarius
force-pushed
the
config-test-cases
branch
3 times, most recently
from
193d7ec to
f356c43
Compare
avelanarius
changed the title
* configurations
Member
Author
|
Integration tests run with this PR: https://github.com/QuesmaOrg/quesma/actions/runs/11497382125 |
avelanarius
requested review from
jakozaur,
mieciu,
nablaone,
pdelewski and
trzysiek
Two small bug fixes related to "*" configuration introduced in b520aca: "target: []" is now allowed for query processor indexes and IsClosed of the decision is now properly filled in for makeDefaultWildcard rule.
Add test_wildcard_clickhouse.go test which checks the "*": target: [clickhouse] scenario (everything goes to ClickHouse) and test_wildcard_disabled.go test which checks the "*": target: [] scenario (all query/ingest is disabled except for explicitly configured indexes).
avelanarius
force-pushed
the
config-test-cases
branch
from
f356c43 to
4b65614
Compare
mieciu
reviewed
Oct 24, 2024
Member
mieciu
left a comment
mieciu
left a comment
There was a problem hiding this comment.
LGTM now let's check it out on the actual worker ;)
https://github.com/QuesmaOrg/quesma/actions/runs/11499654490
mieciu
approved these changes
Oct 24, 2024
Member
|
worked on CI, let's go 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
test_wildcard_clickhouse.gotest which checks the"*": target: [clickhouse]scenario (everything goes to ClickHouse) andtest_wildcard_disabled.gotest which checks the"*": target: []scenario (all query/ingest is disabled except for explicitly configured indexes).Additionally Two small bug fixes related to
"*"configuration introduced in b520aca:target: []is now allowed for query processor indexes andIsClosedof the decision is now properly filled in formakeDefaultWildcardrule.