This repository was archived by the owner on Nov 7, 2025. It is now read-only.
A/B - Performance gain change #967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nablaone
requested review from
avelanarius,
jakozaur,
mieciu,
pdelewski and
trzysiek
Member
Author
|
We should replace "Performance gain" with "Response time delta". We should compute how much clickhouse is faster than elastic. Elastic time is our baseline. |
Member
Author
|
Changed. It's ready for review now. 
|
avelanarius
reviewed
Nov 12, 2024
| buffer.Html(`><a title="Compatibility Report" href="`) | ||
| buffer.Html(abTestingPath) | ||
| buffer.Html(`">A/B</a></li>`) | ||
| buffer.Html(`">CR</a></li>`) |
Member
There was a problem hiding this comment.
Don't forget that there are instances of "A/B testing" still left in ab_testing.go (such as A/B Testing - Panel Details).
It's OK if you want to do it in a followup PR.
avelanarius
reviewed
Nov 12, 2024
Co-authored-by: Piotr Grabowski <[email protected]> Signed-off-by: Rafał Strzaliński <[email protected]>
Member
|
gofmt fails (tabs vs spaces 😢) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a different rendering of performance gain for extreme values: