This repository was archived by the owner on Nov 7, 2025. It is now read-only.
Don't remove Elasticsarch indices/datastreams from _resolve endpoint
#989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mieciu
changed the title
_resolve endpoint_resolve endpoint
mieciu
force-pushed
the
dont-remove-sources
branch
from
dcbe851 to
187f646
Compare
simplify the `_resolve` algorithm by showing all the sources
mieciu
force-pushed
the
dont-remove-sources
branch
from
187f646 to
99fe066
Compare
avelanarius
approved these changes
Nov 19, 2024
pdelewski
approved these changes
Nov 19, 2024
Member
Author
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this is due to some historical reasons which are no longer accurate.
After this patch, you can create data stream with ES index without issues:
At this moment, we simply return all(*) the sources. After all, created data view may outlive Quesma and related routing configuration.
(*) all the Elasticsearch indices/datastreams/aliases matching desired pattern plus our ClickHouse tables presented as Data Streams.
Closes: #996