This repository was archived by the owner on Oct 21, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Reproducible outputs #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f88659 to
2e2eb08
Compare
stared
reviewed
Aug 18, 2025
stared
reviewed
Aug 18, 2025
src/utils/llm_backend.py
Outdated
| """Generate response from OpenRouter model.""" | ||
| # For reproducibility, use temperature=0 when seed is set | ||
| if self.seed is not None: | ||
| temperature = 0.0 |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above.
stared
reviewed
Aug 18, 2025
stared
reviewed
Aug 18, 2025
src/utils/model_client.py
Outdated
Comment on lines
270
to
271
| if self.seed is not None: | ||
| temperature = 0.0 |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again
stared
approved these changes
Aug 18, 2025
Contributor
stared
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments on temperature - otherwise, LGTM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug with re-use session of ollama, which leaked context between sessions. This made some results unpredictable.
Add option
--seed, it works perfectly with local ollama.