Skip to content

Fix regression in beAnInstanceOf #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Fix regression in beAnInstanceOf #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Nimble/Matchers/BeAnInstanceOf.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ public func beAnInstanceOf<T, U>(_ expectedType: T.Type) -> Matcher<U> {
let errorMessage = "be an instance of \(String(describing: expectedType))"
return Matcher.define { actualExpression in
let instance = try actualExpression.evaluate()
guard let validInstance = instance else {
guard let validInstance: Any = instance else {
return MatcherResult(
status: .doesNotMatch,
message: .expectedActualValueTo(errorMessage)
Expand Down
13 changes: 11 additions & 2 deletions Tests/NimbleTests/Matchers/BeAKindOfTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,25 @@ final class BeAKindOfSwiftTest: XCTestCase {
expect(testProtocolClass).to(beAKindOf(TestProtocol.self))
expect(testProtocolClass).toNot(beAKindOf(TestStructConformingToProtocol.self))

expect(testProtocolClass as TestProtocol).to(beAKindOf(TestClassConformingToProtocol.self))
expect(testProtocolClass as TestProtocol).to(beAKindOf(TestProtocol.self))
expect(testProtocolClass as TestProtocol).toNot(beAKindOf(TestStructConformingToProtocol.self))

let testProtocolStruct = TestStructConformingToProtocol()
expect(testProtocolStruct).to(beAKindOf(TestStructConformingToProtocol.self))
expect(testProtocolStruct).to(beAKindOf(TestProtocol.self))
expect(testProtocolStruct).toNot(beAKindOf(TestClassConformingToProtocol.self))

expect(testProtocolStruct as TestProtocol).to(beAKindOf(TestStructConformingToProtocol.self))
expect(testProtocolStruct as TestProtocol).to(beAKindOf(TestProtocol.self))
expect(testProtocolStruct as TestProtocol).toNot(beAKindOf(TestClassConformingToProtocol.self))
}

func testNestedMatchers() {
// This test is successful if it even compiles.
let result: Result<Int, Error> = .success(1)
expect(result).to(beSuccess(beAKindOf(Int.self)))
expect(Result<Int, Error>.success(1)).to(beSuccess(beAKindOf(Int.self)))
expect(Result<TestProtocol, Error>.success(TestClassConformingToProtocol())).to(beSuccess(beAKindOf(TestClassConformingToProtocol.self)))
expect(Result<TestProtocol, Error>.success(TestClassConformingToProtocol())).to(beSuccess(beAKindOf(TestProtocol.self)))
}

func testFailureMessages() {
Expand Down
13 changes: 11 additions & 2 deletions Tests/NimbleTests/Matchers/BeAnInstanceOfTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,25 @@ final class BeAnInstanceOfTest: XCTestCase {
expect(testProtocolClass).toNot(beAnInstanceOf(TestProtocol.self))
expect(testProtocolClass).toNot(beAnInstanceOf(TestStructConformingToProtocol.self))

expect(testProtocolClass as TestProtocol).to(beAnInstanceOf(TestClassConformingToProtocol.self))
expect(testProtocolClass as TestProtocol).toNot(beAnInstanceOf(TestProtocol.self))
expect(testProtocolClass as TestProtocol).toNot(beAnInstanceOf(TestStructConformingToProtocol.self))

let testProtocolStruct = TestStructConformingToProtocol()
expect(testProtocolStruct).to(beAnInstanceOf(TestStructConformingToProtocol.self))
expect(testProtocolStruct).toNot(beAnInstanceOf(TestProtocol.self))
expect(testProtocolStruct).toNot(beAnInstanceOf(TestClassConformingToProtocol.self))

expect(testProtocolStruct as TestProtocol).to(beAnInstanceOf(TestStructConformingToProtocol.self))
expect(testProtocolStruct as TestProtocol).toNot(beAnInstanceOf(TestProtocol.self))
expect(testProtocolStruct as TestProtocol).toNot(beAnInstanceOf(TestClassConformingToProtocol.self))
}

func testNestedMatchers() {
// This test is successful if it even compiles.
let result: Result<Int, Error> = .success(1)
expect(result).to(beSuccess(beAnInstanceOf(Int.self)))
expect(Result<Int, Error>.success(1)).to(beSuccess(beAnInstanceOf(Int.self)))
expect(Result<TestProtocol, Error>.success(TestClassConformingToProtocol())).to(beSuccess(beAnInstanceOf(TestClassConformingToProtocol.self)))
expect(Result<TestProtocol, Error>.success(TestClassConformingToProtocol())).toNot(beSuccess(beAnInstanceOf(TestProtocol.self)))
}

func testFailureMessages() {
Expand Down
Loading