Fix waitUntil, which was broken in the new implementation of polling expectations #1202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…expectations This one is wild, because apparently, RunLoop.run(mode:before:) wasn't actually blocking for the amount of time specified. It was basically spinning the runloop once, then returning. This change now continuously spins the runloop until either the timeout passes, or a result is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is wild, because apparently, RunLoop.run(mode:before:) wasn't actually blocking for the amount of time specified. It was basically spinning the runloop once, then returning. This change now continuously spins the runloop until either the timeout passes, or a result is set.
The PR should summarize what was changed and why. Here are some questions to
help you if you're not sure:
Checklist - While not every PR needs it, new features should consider this list: